GH-37958: [MATLAB] Centralize Command Window hyperlink formatting#49414
Open
kriyanshii wants to merge 3 commits intoapache:mainfrom
Open
GH-37958: [MATLAB] Centralize Command Window hyperlink formatting#49414kriyanshii wants to merge 3 commits intoapache:mainfrom
kriyanshii wants to merge 3 commits intoapache:mainfrom
Conversation
Reduce duplicate hyperlink formatting logic in Command Window display helpers. * Add a shared hyperlink utility in MATLAB display helpers. * Use it in schema string rendering and test helpers. Not run (manual check in MATLAB Command Window). Yes. Command Window display now uses a shared hyperlink helper. * GitHub Issue: apache#37958
kriyanshii
requested review from
kevingurney,
kou and
sgilmore10
as code owners
sgilmore10
reviewed
Mar 3, 2026
matlab/src/matlab/+arrow/+tabular/+internal/+display/getSchemaString.m
Outdated
Show resolved
Hide resolved
github-actions
bot
added
awaiting committer review
Member
|
Hi @kriyanshii, It looks like there's some CI failures. Could you take a look? Thanks, |
Member
|
Please reach out to @kevingurney or me if you have any specific questions that we can answer! Best, |
Author
|
@sgilmore10 yess! |
- Add getClassNameForDisplay, getNumString, makeDimensionString helpers - Update Array, Schema, Tabular, Type, Field display to use short class names with optional hyperlinks - Fix tSchema TestIsEqualTrue/False: use table() instead of table for empty schema
Member
|
Hi @kriyanshii, It looks like there's still some CI failures. I took a quick look at the changes, and it seems like there's more code churn than I expect (e.g. I'm not sure why Do you mind taking a fresh look at this? Best, |
Author
|
I am starting everything cleanly from scratch. Sorry for the delay. |
Member
No worries! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Reduce duplicate hyperlink formatting logic in Command Window display helpers.
What changes are included in this PR?
Are these changes tested?
Not run (manual check in MATLAB Command Window).
Are there any user-facing changes?
Yes. Command Window display now uses a shared hyperlink helper.